Restrict unicode sent to Github API #251
Conversation
This comment has been minimized.
This comment has been minimized.
EnricoMi
force-pushed
the
branch-restrict-json-payload-unicode
branch
from
027c250 to
ef4f2b3
Compare
This comment has been minimized.
This comment has been minimized.
![sonatype-lift[bot]](https://avatars.githubusercontent.com/in/9843?s=60&v=4){kind=small}
|
|
||
|
|
||
| def restrict_unicode_list(texts: List[str]) -> List[str]: | ||
| return [restrict_unicode(text) for text in texts] |
There was a problem hiding this comment.
Incompatible return type: Expected List[str] but got List[Optional[str]].
(at-me in a reply with help or ignore)
Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
Unit Test Results (Test Files) 26 files +1 4 errors 23 suites +1 39m 21s ⏱️ +9s For more details on these parsing errors, failures and errors, see this check. Results for commit 4f8694b. ± Comparison against base commit 0ee9ecd. ♻️ This comment has been updated with latest results. |
|
|
||
|
|
||
| def get_skipped_tests_list_annotation(cases: UnitTestCaseResults, max_chunk_size: int = 64000) -> List[Annotation]: | ||
| return get_test_list_annotation(get_skipped_tests_list(cases), 'skipped test', max_chunk_size) | ||
| return get_test_list_annotation(restrict_unicode_list(get_skipped_tests_list(cases)), 'skipped test', max_chunk_size) |
There was a problem hiding this comment.
Incompatible parameter type: Expected List[str] for 1st positional only parameter to call get_test_list_annotation but got List[Optional[str]].
(at-me in a reply with help or ignore)
Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
| @@ -758,11 +771,11 @@ def get_skipped_tests_list(cases: UnitTestCaseResults) -> List[str]: | |||
|
|
|||
|
|
|||
| def get_all_tests_list_annotation(cases: UnitTestCaseResults, max_chunk_size: int = 64000) -> List[Annotation]: | |||
| return get_test_list_annotation(get_all_tests_list(cases), 'test', max_chunk_size) | |||
| return get_test_list_annotation(restrict_unicode_list(get_all_tests_list(cases)), 'test', max_chunk_size) | |||
There was a problem hiding this comment.
Incompatible parameter type: Expected List[str] for 1st positional only parameter to call get_test_list_annotation but got List[Optional[str]].
(at-me in a reply with help or ignore)
Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
|
|
||
|
|
||
| def get_skipped_tests_list_annotation(cases: UnitTestCaseResults, max_chunk_size: int = 64000) -> List[Annotation]: | ||
| return get_test_list_annotation(get_skipped_tests_list(cases), 'skipped test', max_chunk_size) | ||
| return get_test_list_annotation(restrict_unicode_list(get_skipped_tests_list(cases)), 'skipped test', max_chunk_size) |
There was a problem hiding this comment.
Incompatible parameter type: Expected List[Optional[str]] for 1st positional only parameter to call restrict_unicode_list but got List[str].
(at-me in a reply with help or ignore)
Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
| @@ -758,11 +771,11 @@ def get_skipped_tests_list(cases: UnitTestCaseResults) -> List[str]: | |||
|
|
|||
|
|
|||
| def get_all_tests_list_annotation(cases: UnitTestCaseResults, max_chunk_size: int = 64000) -> List[Annotation]: | |||
| return get_test_list_annotation(get_all_tests_list(cases), 'test', max_chunk_size) | |||
| return get_test_list_annotation(restrict_unicode_list(get_all_tests_list(cases)), 'test', max_chunk_size) | |||
There was a problem hiding this comment.
Incompatible parameter type: Expected List[Optional[str]] for 1st positional only parameter to call restrict_unicode_list but got List[str].
(at-me in a reply with help or ignore)
Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
Fixes #250. Likely related to #212.