Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WorldEdit on Fabric Server causes players to not connect with Java error (packet larger then expected) #2525

Closed
5 tasks done
alotod opened this issue May 9, 2024 · 7 comments
Assignees
Labels
platform:fabric Specific to the Fabric platform platform:forge Specific to the Forge platform status:accepted Will be fixed / added to WorldEdit, eventually type:bug Incorrect behavior, not working as intended
Milestone

Comments

@alotod
Copy link

alotod commented May 9, 2024

WorldEdit Version

7.3.1

Platform Version

Fabric 0.15.11 on Docker

Confirmations

  • I am using the most recent Minecraft release.
  • I am using a version of WorldEdit compatible with my Minecraft version.
  • I am using the latest or recommended version of my platform software.
  • I am NOT using a hybrid server, e.g. a server that combines Bukkit and Forge. Examples include Arclight, Mohist, and Cardboard.
  • I am NOT using a fork of WorldEdit, such as FastAsyncWorldEdit (FAWE) or AsyncWorldEdit (AWE)

Bug Description

After adding the latest mod file into the 'mods' folder and restarting the server, players fail to connect with error:
Internal Exception: io.netty.handler.codec.DecoderException: java.io.IOException: Packet play/serverbound/minecraft:custom_payload (class_2817) was larger than I expected, found 3 bytes extra whilst reading packet serverbound/minecraft:custom_payload.
After removing WorldEdit from the server everyone can join without problem.

Expected Behavior

Every player can join without any issues.

Reproduction Steps

  1. Add the WE file to the mods directory on the server side.
  2. Restart the Minecraft server.
  3. Try to join.

Anything Else?

Other mods on server:

  • Fabric API
  • FerriteCore
  • Lithium
  • spark
  • Chunky
@alotod alotod added status:pending Pending acceptance or closure. type:bug Incorrect behavior, not working as intended labels May 9, 2024
@me4502
Copy link
Member

me4502 commented May 10, 2024

I can't reproduce this issue, is there anything else about your setup that you haven't mentioned?

@dougclow
Copy link

I have a similar issue on Singleplayer - I can connect fine and most things seem to work fine (selecting with the axe, //replace, movement commands) but if I do //sel I get disconnected with:
Internal Exception: io.netty.handler.codec.DecoderException: java.io.IOException: Packet play/clientbound/minecraft:custom_payload (class_2658) was larger than I expected, found 8 bytes extra whilst reading packet clientbound/minecraft:custom_payload

(Fabric but no other mods, native not Docker.)

@dougclow
Copy link

I've done some more systematic testing and tried pretty much every command in the docs apart from schematic, snapshot, and scripting commands, and everything works fine except for:

  • //sel - with and without arguments, except //sel list works and shows the list of options
  • //deselect
  • //pos (with and without arguments)
  • //chunk (with and without arguments)

all of which disconnect me from the game with the same error.

I've not been able to test //curve because I can't get a convex polyhedral selection, because I can't use //sel, but all the other region commands, including //line, //set and //replace, work fine.

Minecraft 1.20.6 with Fabric Loader 0.15.10, Worldedit 7.3.1+6763-2e55f4f. Crash log on a minimal setup for reference.

@aurorasmiles
Copy link
Contributor

aurorasmiles commented May 20, 2024

I've been able to replicate this as described by @dougclow
Using Fabric Loader 0.15.11 on 1.20.6 with WorldEdit 7.3.1, fresh install without any other mods.
Some commands work fine, but //sel for example instantly disconnects me with a similar error

Edit: Funnily enough, //drawsel and then //sel works perfectls fine.
It also throws me into the Multiplayer screen after disconnecting, even if I was in a singleplayer world

@aurorasmiles
Copy link
Contributor

Not sure if it helps, but with additional debugging logs:
https://paste.enginehub.org/IbzRoo9U1

@WithLithum
Copy link

Not sure but it probably has something to do with CUI packets

@octylFractal octylFractal added platform:forge Specific to the Forge platform platform:fabric Specific to the Fabric platform status:accepted Will be fixed / added to WorldEdit, eventually and removed status:pending Pending acceptance or closure. labels May 21, 2024
@octylFractal octylFractal added this to the 7.3.2 milestone May 21, 2024
@octylFractal octylFractal self-assigned this May 21, 2024
@me4502 me4502 closed this as completed May 21, 2024
@dougclow
Copy link

Confirmed fixed for me in WorldEdit 7.3.2 - thanks so much!

(Late followup, sorry, have been travelling.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform:fabric Specific to the Fabric platform platform:forge Specific to the Forge platform status:accepted Will be fixed / added to WorldEdit, eventually type:bug Incorrect behavior, not working as intended
Development

No branches or pull requests

6 participants