Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Commit failures should fail workflow #370

Closed
Josh-Cena opened this issue Mar 3, 2022 · 3 comments · Fixed by #376
Closed

Commit failures should fail workflow #370

Josh-Cena opened this issue Mar 3, 2022 · 3 comments · Fixed by #376
Assignees
@EndBug
Labels
good first issue Good for newcomers status: pinned Should not be labeled as stale type: fix Updates to existing functionalities

Comments

@Josh-Cena
Copy link

Josh-Cena commented Mar 3, 2022 •
edited

Describe the bug

If git commit fails, the workflow still completes despite nothing being pushed.

Workflow used

https://github.com/Josh-Cena/Josh-Cena.github.io/blob/master/.github/workflows/mark-non-coding-day.yml

Expected behavior

The workflow should exit with a non-zero status so GitHub would put a red cross.

Logs

https://github.com/Josh-Cena/Josh-Cena.github.io/runs/5408061374?check_suite_focus=true
@Josh-Cena Josh-Cena added the status: pending More info is needed before deciding what to do label Mar 3, 2022
@EndBug EndBug added type: fix Updates to existing functionalities good first issue Good for newcomers status: pinned Should not be labeled as stale and removed status: pending More info is needed before deciding what to do labels Mar 3, 2022
@EndBug EndBug self-assigned this Mar 3, 2022
@EndBug EndBug mentioned this issue Mar 11, 2022
Merged
@EndBug
Copy link
Owner

EndBug commented Mar 11, 2022

@all-contributors please add @Josh-Cena for their bug report

@allcontributors allcontributors bot mentioned this issue Mar 11, 2022
Merged
@allcontributors
Copy link
Contributor

@EndBug

I've put up a pull request to add @Josh-Cena! 🎉

@Josh-Cena
Copy link
Author

That's quick @EndBug Thanks!

(Didn't get time last week to test, but can confirm it works now!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@EndBug EndBug

Labels
good first issue Good for newcomers status: pinned Should not be labeled as stale type: fix Updates to existing functionalities
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix!: fail when there's an error while committing EndBug/add-and-commit
2 participants
@EndBug @Josh-Cena