Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pull docs are outdated, not reflecting the breaking change #354

Closed
secondmanveran opened this issue Jan 23, 2022 · 4 comments
Closed

pull docs are outdated, not reflecting the breaking change #354

secondmanveran opened this issue Jan 23, 2022 · 4 comments
Assignees
Labels
type: docs Documentation changes

Comments

@secondmanveran
Copy link

Describe the bug
Error: Error: fatal: 'NO-PULL' does not appear to be a git repository

Workflow used

      - name: commit assets to branch
        uses: EndBug/add-and-commit@v8
        with:
          default_author: github_actor
          new_branch: latest
          message: 'chore(deploy): deploy main code to production'
          add: '-f public/'
          pull: 'NO-PULL'
          push: '-f origin latest'

Expected behavior
I expect it to work. Your docs say clearly to enter 'NO_PULL' as an option if you don't want the action to pull. Now suddenly with this new version it breaks.

Logs
https://github.com/jetstreamlabs/jetstreampro/runs/4914677888?check_suite_focus=true

@secondmanveran secondmanveran added the status: pending More info is needed before deciding what to do label Jan 23, 2022
@EndBug EndBug self-assigned this Jan 23, 2022
@EndBug EndBug added type: docs Documentation changes and removed status: pending More info is needed before deciding what to do labels Jan 23, 2022
@EndBug
Copy link
Owner

EndBug commented Jan 23, 2022

Hi, thanks for opening the issue!

This is a breaking change of version 8.0.0, but I forgot to add it to the README and the CHANGELOG... 😅
I've only updated the action manifest, here.

Anyway, you can simply remove the pull input entirely and the action won't pull, this is the new default behavior.
I'll try to fix the docs as soon as possible!

@EndBug EndBug changed the title Error: fatal: 'NO-PULL' does not appear to be a git repository pull docs are outdated, not reflecting the breaking change Jan 23, 2022
@EndBug EndBug closed this as completed in 7b61ff5 Jan 23, 2022
@EndBug
Copy link
Owner

EndBug commented Jan 23, 2022

@all-contributors please add @secondmanveran for their docs contribution

@allcontributors
Copy link
Contributor

@EndBug

I've put up a pull request to add @secondmanveran! 🎉

@EndBug
Copy link
Owner

EndBug commented Jan 23, 2022

This fix has been published in v8.0.1 (also v8 and latest). Thanks again for your contribution ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: docs Documentation changes
Projects
None yet
Development

No branches or pull requests

2 participants