Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add check to allow empty commits if arg is set #352

Merged
merged 4 commits into from Jan 23, 2022

Conversation

mcargille
Copy link
Contributor

Modifies the changed files check to continue the process if the '--allow-empty' argument was passed, even if no files were changed.

@mcargille
Copy link
Contributor Author

Tested and working in one of my private repositories

@mcargille
Copy link
Contributor Author

resolves #350

@EndBug EndBug linked an issue Jan 22, 2022 that may be closed by this pull request
@EndBug EndBug added the type: bug Verified problems that need to be worked on label Jan 22, 2022
Copy link
Owner

@EndBug EndBug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks for submitting the PR!
I've left a couple of suggestions ;)

src/main.ts Outdated Show resolved Hide resolved
src/main.ts Show resolved Hide resolved
@EndBug EndBug merged commit bfbc660 into EndBug:main Jan 23, 2022
@EndBug
Copy link
Owner

EndBug commented Jan 23, 2022

@all-contributors please add @mcargille for their bug report and code contribution

@allcontributors
Copy link
Contributor

@EndBug

I've put up a pull request to add @mcargille! 🎉

@EndBug
Copy link
Owner

EndBug commented Jan 23, 2022

This fix has been published in v8.0.1 (also v8 and latest). Thanks again for your contribution ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Verified problems that need to be worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow-Empty commit argument not working
2 participants