Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tagging support #30

Merged
merged 7 commits into from May 17, 2020
Merged

Add tagging support #30

merged 7 commits into from May 17, 2020

Conversation

ToMe25
Copy link
Contributor

@ToMe25 ToMe25 commented May 16, 2020

This pull request adds the ability to tag the new commit in the same action, by supplying it with a tag name.

If you don't think this matches what this action is meant to do feel free to close this pr.

@EndBug EndBug added type: feature New feature or feature request good first issue Good for newcomers labels May 16, 2020
@EndBug EndBug added this to In progress in Main board via automation May 16, 2020
@EndBug
Copy link
Owner

EndBug commented May 16, 2020

Hey, thanks for the PR! I'll look into it as soon as I can ;)

@EndBug EndBug merged commit c61b317 into EndBug:master May 17, 2020
Main board automation moved this from In progress to Done May 17, 2020
@EndBug
Copy link
Owner

EndBug commented May 17, 2020

Hey, I've added this in v4.2.0 (also available via the v4 and latest refs)
Just a note: if a tag already exists it will be updated, which is different from what you have originally coded: I hope this works out for you, but I guess the majority of people would prefer it like this, since workflows are made to run multiple times, and I see how tagging builds and so would be easier this way.
Thanks again for the PR :)

@ToMe25
Copy link
Contributor Author

ToMe25 commented May 17, 2020

Yes, thats probably the better way.
I wont be able to use this action, as after i created this pr,
i figured out that what i wanted conflicts with the intention(and implementation) of this action.
I have found another way to do it, and hope this addition will help other people :)

@EndBug
Copy link
Owner

EndBug commented Jul 10, 2020

@all-contributors please add @ToMe25 for code and ideas

@allcontributors
Copy link
Contributor

@EndBug

I've put up a pull request to add @ToMe25! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers type: feature New feature or feature request
Projects
No open projects
Main board
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants