Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some checks happen while trying to merge, making react-to-comments slightly unreliable #47

Open
bnjbvr opened this issue Apr 4, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@bnjbvr
Copy link
Contributor

bnjbvr commented Apr 4, 2023

See for instance this (sorry about link to internal repo), where a PR is passing all the checks, so octobors will try to merge the PR, but it aborts because some of the Github checks (in this case, all comments must be closed first) aren't passing yet.

It would be nice if all the checks would happen before the attempt to merge happens, so the comment posted by the bot is more realistic.

@bnjbvr bnjbvr added the bug Something isn't working label Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant