Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bot does not auto merge even though all checks are OK #45

Open
Hoodad opened this issue Mar 8, 2023 · 1 comment
Open

Bot does not auto merge even though all checks are OK #45

Hoodad opened this issue Mar 8, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@Hoodad
Copy link

Hoodad commented Mar 8, 2023

Describe the bug
An internal PR had all reviewers approving and CI verified the status of the build as OK. Still the bot refused to merge.

To Reproduce

  1. Assign three reviewers, one from a team, one manually assigned and one code owner
  2. The CI builds and confirms the code is good
  3. Code owner removes self as the reviewer
  4. Both remaining reviewers approved
  5. Bot adds label "reviewed"

This is how the issue occurred. Though I'm not sure how often this happens if this procedure is repeated....

Expected behavior
The bot would merge once the reviewers approved

@Hoodad Hoodad added the bug Something isn't working label Mar 8, 2023
@bnjbvr
Copy link
Contributor

bnjbvr commented Apr 4, 2023

To debug this kind of situation, you could now enable the react_to_comments in your code base, and ask the bot why it's blocked, whenever that happens.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants