Octobors doesn't find all comments

[tgolsson]

Describe the bug

One of my PRs had received full approval, but the bot wasn't accepting that it was reviewed. While inspecting logs I found that it was reporting the wrong review state:

2023-02-28 15:40:08 | INFO repo{name="xxxx"}:pr{number=8710}: octobors::process: Not yet approved by review
2023-02-28 15:40:08 | INFO repo{name="xxxx"}:pr{number=8710}: octobors::review: review user=repi review=ChangeRequested

Inspecting the list of reviews it reported, I found that the list had only 30 elements, from the start of the PR. Since the latest were missing, I wrote a small code-snippet (see bottom) replicating the merge-check. This code reported 57 reviews and approved. Worth noting is that 30 items is the number of items per page.

This may be related to our usage of ghProxy, as the code here will bypass the proxy for each following link as I can understand it:

octobors/src/context.rs

Lines 69 to 72 in 6b6bbb2

	while let Some(previous) = page {
	reviews.extend(previous.items);
	page = self.inner.get_page(&previous.next).await?;
	}

To Reproduce

No idea.

Expected behavior

All comments are found by the bot.

Additional context

use anyhow::Context;
use octobors::review::{Approval, Review};

#[tokio::main]
async fn main() {
    let token = std::env::var("GITHUB_TOKEN")
        .context("failed to read GITHUB_TOKEN environment variable")
        .unwrap()
        .trim()
        .to_string();

    let client = octobors::context::Client::new(
        token,
        "EmbarkStudios".to_string(),
        Some("https://ghproxy.embark.net/"),
        &[(
            "x-ghproxy-auth".to_owned(),
            "----".to_owned(),
        )],
    )
    .unwrap();

    let res = client.get_pull_request_reviews("xxxx", 8710).await.unwrap();
    dbg!(res.len());
    let reviews =
        octobors::review::Reviews::new("tgolsson", octobors::review::CommentEffect::RequestsChange)
            .record_reviews(
                res.iter()
                    .map(Review::from_octocrab_review)
                    .map(Option::unwrap)
                    .collect(),
            );

    dbg!(&reviews, reviews.approved(Approval::Required));
}