Add maintenance label #40
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TimonPost
commented
Oct 25, 2022
| self.config | ||
| .maintenance_time | ||
| .as_ref() | ||
| .and_then(|maintenance_time| { |
There was a problem hiding this comment.
need to change this a bit
|
A bit divided if we should add scheduling in octobors or if we may get away by using something like: https://github.com/marketplace/actions/schedule-job-action |
|
Can get pretty advanced if we want to do this in octoborus
|
|
Alright, the simplest first effort I think is to just remove the maintenance label to unblock a merge. Then its up to the dev to take care of rebasing properly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description of Changes
Fixes: #39
This adds a maintenance label that if added to PR it will block merging even if all other conditions are med. In addition, octoborus can be configured with a maintenance cron job time that if set will merge all PRs with the maintenance label at the scheduled time.