Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The inactive check is a bit too aggressive #31

Open
bnjbvr opened this issue Aug 29, 2022 · 2 comments
Open

The inactive check is a bit too aggressive #31

bnjbvr opened this issue Aug 29, 2022 · 2 comments
Labels
bug Something isn't working

Comments

@bnjbvr
Copy link
Contributor

bnjbvr commented Aug 29, 2022

Describe the bug

If a PR has been inactive, but its mergeable status goes from blocked (because e.g. required checks haven't passed: a conversation hasn't been marked as resolved and the repo owner mandates that conversations be resolved) to unblocked, then the PR is still considered inactive (i.e. its last update time isn't updated). As a matter of fact, the bot won't merge such a pull request, and needs to be manually woken up.

To Reproduce
Steps to reproduce the behavior:

  1. In a repo that mandates conversations to be resolved before merging, open a PR
  2. open a conversation in that PR
  3. get a proper review from that PR, so octobors marks it as reviewed (and tries to queue it for merge)
  4. resolve the conversation

Expected behavior
The bot should merge the next time it runs (in narrator's voice: it does not, and instead considers the PR to be inactive).

@bnjbvr bnjbvr added the bug Something isn't working label Aug 29, 2022
@maxded maxded closed this as completed Sep 11, 2023
@maxded maxded reopened this Sep 11, 2023
@thefuntastic
Copy link
Member

Follow up to see if this is still an issue with the new merge queue

@davidpdrsn
Copy link
Member

Technically it's still an issue, we just don't use octobors internally as much. So its not much of an issue for us.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants