tests: test_splice_disconnect_sig fails with bad commit sig

[daywalker90]

The test in test_splicing_disconnect.py fails alot in CI. Right before the creation of the invoice you can see this in the logs:

lightningd-1 2024-04-19T14:59:42.975Z DEBUG   022d223620a359a47ff7f7ac447c85c46c923da53389221a0054c11c1e3ca31d59-channeld-chan#1: Derived key 039b7fec1eae7d1c3ebe2c75bad7a0446e54a58eb17ea7fc8b79b663760df15461 from basepoint 03e0a7bb422b254f54bc954be05bd6823a7b7a4b996ff8d3079ca211590fb5df39, point 03ea98cd6ba5a6de1bb2b3cbe05740bfe56b3482143704b27db6565638dfe58a64
lightningd-1 2024-04-19T14:59:42.976Z DEBUG   022d223620a359a47ff7f7ac447c85c46c923da53389221a0054c11c1e3ca31d59-channeld-chan#1: peer_out WIRE_WARNING
lightningd-1 2024-04-19T14:59:42.976Z DEBUG   022d223620a359a47ff7f7ac447c85c46c923da53389221a0054c11c1e3ca31d59-channeld-chan#1: billboard perm: Bad commit_sig signature 1 304402207793c14bc92ddfa4c0b4d4ac0d6c7c70d80dbe2c5b12bd45b80c2ba42f63d874022021a077aed7289e925e37b74fd139ef535fea56d6956d6afeb0facb4deadc7f5201 for tx 02000000013b742fb7665f9d2dc9cedfbaafa9ca0d2b9e410ee450350637a51ecb46cc102900000000009db0e280024a01000000000000220020be7935a77ca9ab70a4b8b1906825637767fed3c00824aa90c988983587d68488d0b510000000000022002091fb9e7843a03e66b4b1173482a0eb394f03a35aae4c28e8b4b1f575696bd7939b3ed620 wscript 522102324266de8403b3ab157a09f1f784d587af61831c998c151bcc21bb74c2b2314b2102e3bd38009866c9da8ec4aa99cc4ea9c6c0dd46df15c61ef0ce1f271291714e5752ae key 02e3bd38009866c9da8ec4aa99cc4ea9c6c0dd46df15c61ef0ce1f271291714e57 feerate 3755. Cur funding 3b742fb7665f9d2dc9cedfbaafa9ca0d2b9e410ee450350637a51ecb46cc1029, splice_info: 03fcc3a1daf54f584282f978a556583f6dc45db6467723b74eed82168daa8a14, race_await_commit: no, inflight splice count: 0
lightningd-1 2024-04-19T14:59:42.976Z INFO    022d223620a359a47ff7f7ac447c85c46c923da53389221a0054c11c1e3ca31d59-chan#1: Peer transient failure in CHANNELD_NORMAL: channeld sent Bad commit_sig signature 1 304402207793c14bc92ddfa4c0b4d4ac0d6c7c70d80dbe2c5b12bd45b80c2ba42f63d874022021a077aed7289e925e37b74fd139ef535fea56d6956d6afeb0facb4deadc7f5201 for tx 02000000013b742fb7665f9d2dc9cedfbaafa9ca0d2b9e410ee450350637a51ecb46cc102900000000009db0e280024a01000000000000220020be7935a77ca9ab70a4b8b1906825637767fed3c00824aa90c988983587d68488d0b510000000000022002091fb9e7843a03e66b4b1173482a0eb394f03a35aae4c28e8b4b1f575696bd7939b3ed620 wscript 522102324266de8403b3ab157a09f1f784d587af61831c998c151bcc21bb74c2b2314b2102e3bd38009866c9da8ec4aa99cc4ea9c6c0dd46df15c61ef0ce1f271291714e5752ae key 02e3bd38009866c9da8ec4aa99cc4ea9c6c0dd46df15c61ef0ce1f271291714e57 feerate 3755. Cur funding 3b742fb7665f9d2dc9cedfbaafa9ca0d2b9e410ee450350637a51ecb46cc1029, splice_info: 03fcc3a1daf54f584282f978a556583f6dc45db6467723b74eed82168daa8a14, race_await_commit: no, inflight splice count: 0
lightningd-1 2024-04-19T14:59:42.977Z DEBUG   022d223620a359a47ff7f7ac447c85c46c923da53389221a0054c11c1e3ca31d59-connectd: discard_peer
lightningd-2 2024-04-19T14:59:42.978Z DEBUG   0266e4598d1d3c415f572a8488830b60f7e744ed9235eb0b1ba93283b315c03518-gossipd: handle_recv_gossip: WIRE_CHANNEL_UPDATE
lightningd-2 2024-04-19T14:59:42.978Z DEBUG   0266e4598d1d3c415f572a8488830b60f7e744ed9235eb0b1ba93283b315c03518-channeld-chan#1: peer_in WIRE_ANNOUNCEMENT_SIGNATURES
lightningd-2 2024-04-19T14:59:42.978Z DEBUG   lightningd: updating channel 8408133x2677426x48128 with inbound settings
lightningd-1 2024-04-19T14:59:42.980Z DEBUG   connectd: drain_peer
lightningd-1 2024-04-19T14:59:42.980Z DEBUG   022d223620a359a47ff7f7ac447c85c46c923da53389221a0054c11c1e3ca31d59-lightningd: peer_disconnect_done
lightningd-1 2024-04-19T14:59:42.980Z DEBUG   022d223620a359a47ff7f7ac447c85c46c923da53389221a0054c11c1e3ca31d59-lightningd: Will try reconnect in 2 seconds
lightningd-1 2024-04-19T14:59:42.981Z DEBUG   connectd: maybe_free_peer freeing peer!
lightningd-1 2024-04-19T14:59:42.981Z DEBUG   plugin-funder: Cleaning up inflights for peer id 022d223620a359a47ff7f7ac447c85c46c923da53389221a0054c11c1e3ca31d59
lightningd-2 2024-04-19T14:59:42.983Z DEBUG   hsmd: Client: Received message 4 from client
lightningd-2 2024-04-19T14:59:42.983Z DEBUG   connectd: drain_peer
lightningd-2 2024-04-19T14:59:42.983Z DEBUG   0266e4598d1d3c415f572a8488830b60f7e744ed9235eb0b1ba93283b315c03518-channeld-chan#1: peer_in WIRE_WARNING
lightningd-2 2024-04-19T14:59:42.983Z DEBUG   connectd: drain_peer draining subd!
lightningd-2 2024-04-19T14:59:42.983Z INFO    0266e4598d1d3c415f572a8488830b60f7e744ed9235eb0b1ba93283b315c03518-channeld-chan#1: Received WARNING channel 252d1b0a1e57895e84137f28cf19ab2c35847e284c112fefdecc7afeaa5c1de7: Bad commit_sig signature 1 304402207793c14bc92ddfa4c0b4d4ac0d6c7c70d80dbe2c5b12bd45b80c2ba42f63d874022021a077aed7289e925e37b74fd139ef535fea56d6956d6afeb0facb4deadc7f5201 for tx 02000000013b742fb7665f9d2dc9cedfbaafa9ca0d2b9e410ee450350637a51ecb46cc102900000000009db0e280024a01000000000000220020be7935a77ca9ab70a4b8b1906825637767fed3c00824aa90c988983587d68488d0b510000000000022002091fb9e7843a03e66b4b1173482a0eb394f03a35aae4c28e8b4b1f575696bd7939b3ed620 wscript 522102324266de8403b3ab157a09f1f784d587af61831c998c151bcc21bb74c2b2314b2102e3bd38009866c9da8ec4aa99cc4ea9c6c0dd46df15c61ef0ce1f271291714e5752ae key 02e3bd38009866c9da8ec4aa99cc4ea9c6c0dd46df15c61ef0ce1f271291714e57 feerate 3755. Cur funding 3b742fb7665f9d2dc9cedfbaafa9ca0d2b9e410ee450350637a51ecb46cc1029, splice_info: 03fcc3a1daf54f584282f978a556583f6dc45db6467723b74eed82168daa8a14, race_await_commit: no, inflight splice count: 0
lightningd-2 2024-04-19T14:59:42.984Z DEBUG   0266e4598d1d3c415f572a8488830b60f7e744ed9235eb0b1ba93283b315c03518-lightningd: peer_disconnect_done
lightningd-2 2024-04-19T14:59:42.984Z DEBUG   0266e4598d1d3c415f572a8488830b60f7e744ed9235eb0b1ba93283b315c03518-lightningd: Already reconnecting
lightningd-2 2024-04-19T14:59:42.984Z INFO    0266e4598d1d3c415f572a8488830b60f7e744ed9235eb0b1ba93283b315c03518-channeld-chan#1: Peer connection lost
lightningd-2 2024-04-19T14:59:42.984Z INFO    0266e4598d1d3c415f572a8488830b60f7e744ed9235eb0b1ba93283b315c03518-chan#1: Peer transient failure in CHANNELD_NORMAL: channeld: Owning subdaemon channeld died (62208)

It fails locally for me aswell (4 out of 4 times tried)