Ignore --ignore-fee-rates on mutual close, don't massively overpay with LDK nodes #7252
+19
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Concept ACK, appreciate this. Have not tested this yet but from investigations on our side, it sounds like this would fix the issue. |
vincenzopalazzo
approved these changes
Apr 23, 2024
There was a problem hiding this comment.
ACK 0567ac4
Make sense, iirc we use this ignore fee to avoid disable the channel but when we need to touch the chain it is good that we enforce our point of view, this should also possible bugs
Thanks
rustyrussell
force-pushed
the
guilt/mutual-close-no-ignore
branch
from
0567ac4
to
7ae1816
Compare
|
Ok the CI cached the following crash, that looks like unrelated, but I will give another un before merging the PR |
rustyrussell
force-pushed
the
guilt/mutual-close-no-ignore
branch
2 times, most recently
from
0ee1f8f
to
fc45c1f
Compare
niftynei
approved these changes
May 20, 2024
Thought it's intuitive, it's not documented to, and LDK's current behavior makes it quite dangerous to do so. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
rustyrussell
force-pushed
the
guilt/mutual-close-no-ignore
branch
2 times, most recently
from
ed92370
to
f040f58
Compare
|
Fixed timeout caused by close taking forever in test_fee_limits... |
There was a problem hiding this comment.
genidx doc/index.rst
Checking for generated files being changed by make
git diff --exit-code HEAD
diff --git a/contrib/pyln-grpc-proto/pyln/grpc/node_pb2.py b/contrib/pyln-grpc-proto/pyln/grpc/node_pb2.py
index 2ea52d86d..665aa592c 100644
--- a/contrib/pyln-grpc-proto/pyln/grpc/node_pb2.py
+++ b/contrib/pyln-grpc-proto/pyln/grpc/node_pb2.py
@@ -1,6 +1,7 @@
# -*- coding: utf-8 -*-
# Generated by the protocol buffer compiler. DO NOT EDIT!
# source: node.proto
+# Protobuf Python Version: 4.25.1
"""Generated protocol buffer code."""
from google.protobuf import descriptor as _descriptor
from google.protobuf import descriptor_pool as _descriptor_pool
diff --git a/contrib/pyln-grpc-proto/pyln/grpc/primitives_pb2.py b/contrib/pyln-grpc-proto/pyln/grpc/primitives_pb2.py
index b55614db6..955eb91af 100644
--- a/contrib/pyln-grpc-proto/pyln/grpc/primitives_pb2.py
+++ b/contrib/pyln-grpc-proto/pyln/grpc/primitives_pb2.py
@@ -1,6 +1,7 @@
# -*- coding: utf-8 -*-
# Generated by the protocol buffer compiler. DO NOT EDIT!
# source: primitives.proto
+# Protobuf Python Version: 4.25.1
"""Generated protocol buffer code."""
from google.protobuf import descriptor as _descriptor
from google.protobuf import descriptor_pool as _descriptor_pool
make: *** [Makefile:599: check-gen-updated] Error 1
Not clear why this is happening, but looks like the diff for the pylon-grpc-proto package is not necessary.
rustyrussell
force-pushed
the
guilt/mutual-close-no-ignore
branch
from
f040f58
to
a86e31a
Compare
LDK will pick the *upper* limit (see: lightningdevkit/rust-lightning#3014)! It should not do this, but since you can set a manual range for mutual close, it's probably better to disable this option for close, as it's even more dangerous than documented. Changelog-Changed: config/JSON: --ignore-fee-limits / setchannel ignorefeelimits no longer applies to mutual close. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> Fixes: ElementsProject#7242
rustyrussell
force-pushed
the
guilt/mutual-close-no-ignore
branch
from
a86e31a
to
c545f57
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#7242 describes the pain this causes :(
Fixes #7242