Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nodes shouldn't publish their commitment when receiving outdated channel_reestablish #4927

Closed
t-bast opened this issue Nov 23, 2021 · 2 comments
Closed

Nodes shouldn't publish their commitment when receiving outdated channel_reestablish #4927

t-bast opened this issue Nov 23, 2021 · 2 comments

Comments

@t-bast
Copy link

t-bast commented Nov 23, 2021

When receiving a channel_reestablish that indicates that your peer has outdated data, you shouldn't close instantly.
You should only trigger the force-close when receiving an error message from your peer.
This gives them an opportunity to correct it and potentially prevent the force-close.

See lightning/bolts#934 for details.
@whitslack
Copy link
Collaborator

I believe this was fixed in b698a5a and this issue should be closed. @rustyrussell @cdecker

@cdecker cdecker mentioned this issue Jan 7, 2023
Open
@cdecker
Copy link
Member

cdecker commented Jan 7, 2023

Seems reasonable, and the fact that someone tripped up on it already suggests it is actually working 🥴

@cdecker cdecker closed this as completed Jan 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@cdecker @whitslack @t-bast