Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid syntax while trying to build js-wrappers #108

Closed
Sjors opened this issue Jun 4, 2019 · 2 comments
Closed

Invalid syntax while trying to build js-wrappers #108

Sjors opened this issue Jun 4, 2019 · 2 comments

Comments

@Sjors
Copy link
Contributor

Sjors commented Jun 4, 2019

On macOS 10.14.5 with Python 3.7.3 and Node v10.16.0. I think this fails because print "%s.%s.%s" % sys.version_info[:3]; is Python 2 syntax.

./configure --enable-debug --enable-export-all --enable-swig-python --enable-coverage --enable-js-wrappers
make

Fails with:

cd wrap_js && LIBWALLY_DIR=../.. npm_config_debug=1 yarn install
  CCLD     test_bech32
  CCLD     test_tx
yarn install v1.16.0
[1/4] 🔍  Resolving packages...
[2/4] 🚚  Fetching packages...
[3/4] 🔗  Linking dependencies...
[4/4] 🔨  Building fresh packages...
$ node-gyp configure && node-gyp build
[##########################################################################################################################] 242/242gyp info it worked if it ends with ok
gyp info using node-gyp@3.8.0
gyp info using node@10.16.0 | darwin | x64
gyp ERR! configure error 
gyp ERR! stack Error: Command failed: /Users/sjors/.pyenv/shims/python -c import sys; print "%s.%s.%s" % sys.version_info[:3];
gyp ERR! stack   File "<string>", line 1
gyp ERR! stack     import sys; print "%s.%s.%s" % sys.version_info[:3];
gyp ERR! stack                                ^
gyp ERR! stack SyntaxError: invalid syntax
@lvaccaro
Copy link
Contributor

I think node-gyp package doesn’t work on Python 3, open issue: nodejs/node-gyp#1337 .
You could install successfully node-gyp using Python 2, and then build libwally with Python 3.

@jgriffiths
Copy link
Contributor

The old JS wrappers have been removed in favour of the npm auto-generated wrappers, closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants