Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change defaults #16

Closed
niftylettuce opened this issue May 10, 2016 · 8 comments
Closed

Change defaults #16

niftylettuce opened this issue May 10, 2016 · 8 comments

Comments

@niftylettuce
Copy link
Contributor

Don't you need to change https://github.com/meetearnest/eslint-config-earnest-es7/blob/master/index.js#L50 and https://github.com/meetearnest/eslint-config-earnest-es7/blob/master/index.js#L51 to "either" per standard/standard#182?

@niftylettuce
Copy link
Contributor Author

I meant 0 for off***

@yjhuoh
Copy link

yjhuoh commented May 11, 2016

phoenixspray

@niftylettuce
Copy link
Contributor Author

haha what

@niftylettuce
Copy link
Contributor Author

I can close this, I extended it with my own rules, but I thought these were different from standard, not sure, haha

@jsatk
Copy link
Contributor

jsatk commented May 11, 2016

Thanks for the feedback @niftylettuce. Will look into it.

@bromanko
Copy link
Contributor

I think @niftylettuce's proposal is reasonable and in line with how we treat spaces in array literals. I suggest we change object-curly-spacing to 0.

@moredip, @jsatk what say you?

@jsatk
Copy link
Contributor

jsatk commented May 25, 2016

@bromanko I agree. Sounds good to me.

@moredip
Copy link

moredip commented May 25, 2016

Fine with me.
On May 25, 2016 11:07 AM, "Jesse Atkinson" notifications@github.com wrote:

@bromanko https://github.com/bromanko I agree. Sounds good to me.


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#16 (comment)

bromanko pushed a commit that referenced this issue May 25, 2016
bromanko added a commit that referenced this issue May 25, 2016
Change object-curly-spacing per #16
@yjhuoh yjhuoh closed this as completed Jun 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants