Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terminate to implement the auto loaders infra #216

Open
3 tasks
prusse-martin opened this issue Dec 16, 2021 · 0 comments
Open
3 tasks

Terminate to implement the auto loaders infra #216

prusse-martin opened this issue Dec 16, 2021 · 0 comments

Comments

@prusse-martin
Copy link
Member

prusse-martin commented Dec 16, 2021

The switch from explicit loaders (each description has a loader function) to auto loaders (attributes have metadata that allow a suitable loaders to be used) begun with the introduction of multidata support. But most explicit loaders have been left in-place for the unaffected descriptions.
A full switch will facilitate further development/addition of descriptions.
An example is #210, where the changes to explicit loaders will not be necessary.

  • Port all description declarations to populate the metadata (when it is not a plain value like a str, int, or bool), see attrib_scalar, attrib_scalar, attrib_scalar, attrib_scalar, attrib_instance_list, attrib_enum, ... (the ones with "metadata"), Update all Array properties so we can automatically convert those from "alfacase" #199 is related to this;
  • Make the explicit loaders progressivelly just return the result of load_instance(TYPE_OF_DESCRIPTION);
  • Update alfacase_to_case_helper to not use explicit loaders than remove the explicit loaders (some exist just for the sake of the test there and is no longer used in production);
@prusse-martin prusse-martin changed the title Terminate to imp-lement the auto loaders infra Terminate to implement the auto loaders infra Jan 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant