Skip to content

Hybrid package #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Dec 28, 2021
Merged

Hybrid package #42

merged 6 commits into from
Dec 28, 2021

Conversation

ElyDotDev
Copy link
Contributor

Initial implementation of the hybrid package.
Fixes #41

Changes:

  • 4 Packages downgraded to previous CommonJS version, as the index.cjs file is the actual implementation and cannot import ESM modules.
  • The Styleling custom formatted function should be synced so the other way by using await import('./index.mjs') is not feasible.

I didn't check it with webpack/gulp or grunt. I imported it directly in a script JS file both in ESM and CJS packages. Also passing to the CLI checked.

@mrcgrtz mrcgrtz self-requested a review November 24, 2021 23:40
ElyDotDev and others added 4 commits November 25, 2021 12:40

Verified

This commit was signed with the committer’s verified signature. The key has expired.
mrcgrtz Marc Görtz

Verified

This commit was signed with the committer’s verified signature. The key has expired.
mrcgrtz Marc Görtz

Verified

This commit was signed with the committer’s verified signature. The key has expired.
mrcgrtz Marc Görtz
* origin/main:
  Bump plur from 5.0.0 to 5.1.0 (mrcgrtz#47)
  Update FUNDING.yml
  Bump log-symbols from 5.0.0 to 5.1.0 (mrcgrtz#46)
  Bump chalk from 4.1.2 to 5.0.0 (mrcgrtz#43)
  Update funding
  Update FUNDING.yml
  Bump xo from 0.46.4 to 0.47.0 (mrcgrtz#44)
@coveralls
Copy link

coveralls commented Dec 28, 2021

Coverage Status

Coverage increased (+0.2%) to 91.756% when pulling 669c22b on ElyDotDev:hybridPackage into a9e5474 on Dreamseer:main.

@mrcgrtz mrcgrtz merged commit f8cdd4e into mrcgrtz:main Dec 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ESM version (3.x) not working with Stylelint CLI
3 participants