From 1c049d981aeb4e8dd0ef1471cec2cd6e33532cb2 Mon Sep 17 00:00:00 2001 From: Simon Johansson Date: Fri, 17 Feb 2023 10:01:36 +0100 Subject: [PATCH] fix(ssr): reset current instance if setting up options component errors close #7733 --- packages/runtime-core/src/component.ts | 9 ++-- .../server-renderer/__tests__/render.spec.ts | 41 +++++++++++++++++++ 2 files changed, 47 insertions(+), 3 deletions(-) diff --git a/packages/runtime-core/src/component.ts b/packages/runtime-core/src/component.ts index 7048dc07685..51e0f6f2bcc 100644 --- a/packages/runtime-core/src/component.ts +++ b/packages/runtime-core/src/component.ts @@ -903,9 +903,12 @@ export function finishComponentSetup( if (__FEATURE_OPTIONS_API__ && !(__COMPAT__ && skipOptions)) { setCurrentInstance(instance) pauseTracking() - applyOptions(instance) - resetTracking() - unsetCurrentInstance() + try { + applyOptions(instance) + resetTracking() + } finally { + unsetCurrentInstance() + } } // warn missing template/render diff --git a/packages/server-renderer/__tests__/render.spec.ts b/packages/server-renderer/__tests__/render.spec.ts index b0c3a8236fe..0c8ced159f2 100644 --- a/packages/server-renderer/__tests__/render.spec.ts +++ b/packages/server-renderer/__tests__/render.spec.ts @@ -793,6 +793,47 @@ function testRender(type: string, render: typeof renderToString) { } catch {} expect(getCurrentInstance()).toBe(prev) }) + + // #7733 + test('reset current instance after error in data', async () => { + const prev = getCurrentInstance() + expect(prev).toBe(null) + try { + await render( + createApp({ + data() { + throw new Error() + }, + template: `
hello
` + }) + ) + } catch {} + expect(getCurrentInstance()).toBe(null) + }) + }) + + // #7733 + test('reset current instance after error in errorCaptured', async () => { + const prev = getCurrentInstance() + + expect(prev).toBe(null) + try { + await render( + createApp({ + errorCaptured() { + throw new Error() + }, + template: `
hello
`, + created() { + throw new Error() + } + }) + ) + } catch {} + expect( + 'Unhandled error during execution of created hook' + ).toHaveBeenWarned() + expect(getCurrentInstance()).toBe(null) }) test('serverPrefetch', async () => {