Fixes sort-by's handling of multiple keys
#375
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukemelia
force-pushed
the
bug/sort-by-multiple-keys
branch
from
a4751a6 to
ab2c9da
Compare
- Prior to this change, passing multiple keys to `sort-by` resulted in the target array being sorted by the first key and then the whole thing being resorted by each subsequent key. The ultimate result was determined solely by the last key. This is not the intended behavior. - The desired behavior (and the behavior of this addon prior to 4.1.0) is for the second and subsequent sort keys only to be applied in the case where the first sort key does not yield a clear ordering. - The test for this case uses the very common example of sorting people by last name then first name, as is shown in the README - This commit also consolidates the code path taken when a sort function is passed in place of a sort key
lukemelia
force-pushed
the
bug/sort-by-multiple-keys
branch
from
ab2c9da to
01e1caf
Compare
snewcomer
approved these changes
Jun 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sort-byresulted in the target array being sorted by the first key and then the whole thing being resorted by each subsequent key. The ultimate result was determined solely by the last key. This is not the intended behavior.