Skip to content

add a changelog #368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 5, 2020
Merged

add a changelog #368

merged 1 commit into from
Jun 5, 2020

Conversation

mansona
Copy link
Contributor

@mansona mansona commented Jun 4, 2020

Hey folks 👋 this is mostly to open a discussion about adding a changelog.

I created one really quick using https://www.npmjs.com/package/auto-changelog so I've not spent any time on this 😂

The reason I'm bringing up this discussion is that there seems to be some regression between 3.x and 4.x of this addon and I wanted to investigate what changed, but there was no documentation in a changelog or the releases.

@mansona
Copy link
Contributor Author

mansona commented Jun 4, 2020

Turns out that having a changelog really helped me identify the problem 🎉 it is actually a regression between 4.0 and 4.1 because of #362

I've commented on the PR that looks to fix the issue to mention that I'm seeing the same problem 👍

@jrjohnson
Copy link
Contributor

Either a change log or github release notes for each version would make upgrading much easier. I tend to prefer the release notes personally as they are easier to build into a deploy process since the CHANGELOG has to be committed before a release and tends to be a partially manual process.

@mansona
Copy link
Contributor Author

mansona commented Jun 4, 2020

@jrjohnson apparently there is a trick with this auto-changelog that means it will automatically update your changelog when you run npm version or yarn version to update the package.json version and tag the repo. It will also automatically work with np so if that is already part of the release process this can be 100% automated 😱

@snewcomer snewcomer merged commit 9e4bc3c into DockYard:master Jun 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants