Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix duplicate items in campaign.topics in GET /campaigns response #1056

Open
aaronschachter opened this issue Jun 25, 2018 · 0 comments
Open

Fix duplicate items in campaign.topics in GET /campaigns response #1056

aaronschachter opened this issue Jun 25, 2018 · 0 comments
Assignees
@aaronschachter

Comments

@aaronschachter
Copy link
Contributor

aaronschachter commented Jun 25, 2018 •
edited

BUG

Current Behavior

  • The topics property of a data item in a GET /campaigns request will contain duplicates if it has more than one defaultTopicTrigger referencing it.

Desired Behavior

  • All items of the topics array property should be unique.

Steps to Replicate

  • Create two defaultTopicTriggers for a campaign topic, and verify the topic appears twice in the GET /campaigns index response for the campaign.

Why This Matters

When we look to support multiple topics per campaign, this would be a 🐛. Found in #1055 (comment)
@aaronschachter aaronschachter self-assigned this Jun 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aaronschachter aaronschachter

Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@aaronschachter