Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should handle Redis reconnection errors more gracefully #1049

Open
rapala61 opened this issue May 31, 2018 · 0 comments
Open

Should handle Redis reconnection errors more gracefully #1049

rapala61 opened this issue May 31, 2018 · 0 comments

Comments

@rapala61
Copy link
Contributor

BUG

Current Behavior

  • Today, while Redis was being updated by Heroku. The Redis instance was inaccessible for a few minutes. This made G-Campaigns unable to connect. Throwing an ugly exception.

    2018-05-31T08:10:59.398388+00:00 app[web.10]: error: redisClient connection error: Error: Redis 
    connection to ec2-34-200-108-148.compute-1.amazonaws.com:10419 failed - connect 
    ECONNREFUSED 34.200.108.148:10419
    2018-05-31T08:10:59.400628+00:00 app[web.10]: /app/config/redis.js:21
    2018-05-31T08:10:59.400630+00:00 app[web.10]:       throw error;
    2018-05-31T08:10:59.400632+00:00 app[web.10]:       ^
    2018-05-31T08:10:59.400633+00:00 app[web.10]: 
    2018-05-31T08:10:59.400635+00:00 app[web.10]: Error: Redis connection to ec2-34-200-108-
    148.compute-1.amazonaws.com:10419 failed - connect ECONNREFUSED 34.200.108.148:10419
    2018-05-31T08:10:59.400636+00:00 app[web.10]:     at Object._errnoException (util.js:1022:11)
    2018-05-31T08:10:59.400637+00:00 app[web.10]:     at _exceptionWithHostPort (util.js:1044:20)
    2018-05-31T08:10:59.400639+00:00 app[web.10]:     at TCPConnectWrap.afterConnect [as 
    oncomplete] (net.js:1198:14)
    2018-05-31T08:11:00.092585+00:00 app[web.10]: info: Started worker 296
    

Desired Behavior

  • Handle this disconnection more gracefully.

Steps to Replicate

  • set the REDIS_URL with an invalid port
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant