Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tabs Review Updates #998

Open
Darper opened this issue Dec 12, 2018 · 0 comments
Open

Tabs Review Updates #998

Darper opened this issue Dec 12, 2018 · 0 comments

Comments

@Darper
Copy link
Contributor

Darper commented Dec 12, 2018

A list of updates to make to Tabs, Tab, TabList, and TabPanel after doing a group code review.

  • Change onSelect to onChange in Tabs.js
  • Add onBeforeChange
  • Replace cwrp with componentDidUpdate
  • Change selectedIndex to activeIndex
  • Kill TabList if possible
  • Ignore selected prop in Tab docs if only used as pass through from parent, otherwise kill
  • Change setSelectedTab in Tab to onChange and return active state
  • Move padding from .bordered to .tabPanel in TabPanel
  • Change bordered prop to border
  • Kill icon prop
  • Kill tabIndex prop
  • Ignore vertical prop in Tab docs
  • Change Tabs to TabList
  • Kill Tab
  • Rename TabPanel to Tab and offer title prop which accepts a node
  • TabList (new) will loop through Tab components, get titles, and create Tab Header div
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant