New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Icon Review Updates #996

Open

Darper opened this issue Dec 12, 2018 · 0 comments

Contributor

Darper commented Dec 12, 2018

Make the following changes found during a code review of the Icon component:

Update classes in docs from "fa" to "fab"
Update docs to tell user to include their own icon library and update classes
Include code snippet to show how to use font-awesome
Mark icon prop as required
Remove console.warn on line 14
Allow ...others
Remove onClick as it is included in ...others
Change large to compose from .font-size-1 and small to use .font-size-5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment