Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Card Review Updates #995

Open
Darper opened this issue Dec 12, 2018 · 0 comments
Open

Card Review Updates #995

Darper opened this issue Dec 12, 2018 · 0 comments

Comments

@Darper
Copy link
Contributor

Darper commented Dec 12, 2018

Make the following changes found during a code review of the Card component:

  • Change title proptype to allow .node
  • At minimum, change standardFieldset to fieldset and always use title instead of needed legend ... maybe just kill fieldset option (and legend)
  • At maximum, kill fieldset
  • pass through ...others, use blacklist if necessary
  • Pass ...others into wrapper div or fieldset
  • kill cardBody on line 24, put wrapper div and {children} in line 43
  • Replace null on line 45 with block from lines 29-32
  • Only render {card} and kill line 49
  • Possibly pull out card logic from render function into function
  • Kill React.Fragment and call new card method

Tests

  • Line 28 change Accordion to Card
  • Kill test on line 38
  • Add unit tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant