Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Form validate prop should not be passed down to html form element #980

Open
stuller opened this issue Nov 21, 2018 · 0 comments
Open

Form validate prop should not be passed down to html form element #980

stuller opened this issue Nov 21, 2018 · 0 comments
Labels

Comments

@stuller
Copy link
Contributor

stuller commented Nov 21, 2018

The doc site has a js error caused by the validate prop getting passed down to the html form element:
image

Fix should just be adding validate to the blacklist in this line like so:
const othersFiltered = blacklist(others, "onSubmit", "validate");

That will prevent it from getting added to the form dom element, since it only gets othersFiltered.
We are already using this to populate the noValidate attribute on the dom element, so removing this should not disrupt functionality.

You'll need to update snapshot test as well before putting in a PR.

@stuller stuller added the bug label Nov 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant