Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Date Picker defects while used in GC #957

Open
ericsewalson opened this issue Sep 18, 2018 · 0 comments
Open

Date Picker defects while used in GC #957

ericsewalson opened this issue Sep 18, 2018 · 0 comments
Labels

Comments

@ericsewalson
Copy link
Contributor

2 defects:

  1. Passed in selected value cannot be overridden by selecting a new date.
  2. Need to add an onSelect prop instead of onchange to account for the user selecting today or the same date. This is not important for future dates but is relevant when selecting today as the date since the value defaults to today (and doesn't register an onChange event if the date is not changed from default)
Darper added a commit to Darper/react-atlas that referenced this issue Nov 8, 2018
…pletely. Use react-datepicker in the future.
Darper added a commit to Darper/react-atlas that referenced this issue Nov 8, 2018
…pletely. Use react-datepicker in the future.
hbowden added a commit that referenced this issue Nov 8, 2018
Fixes issue #957 by removing the DatePicker component completely. Use…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant