Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS browser consistency on button focus #938

Open
stuller opened this issue Aug 9, 2018 · 0 comments
Open

CSS browser consistency on button focus #938

stuller opened this issue Aug 9, 2018 · 0 comments

Comments

@stuller
Copy link
Contributor

stuller commented Aug 9, 2018

Buttons in IE and FF are showing a dotted line around the text when they receive focus.
image

Browsers add this line to make it easier for people who use keyboard instead of mouse to be able to tell that the button is in focus - so it's not a defect, it's an accessibility feature.

However, we'd like behavior to be the same in all browsers. Chrome adds an outline to the whole button - but it's not really clear in Atlas because the color is similar to the primary button color.

We should update css for focus on buttons to:

  1. remove the dotted line in IE and FF
  2. in all browsers, display an 3px outline on focus using the darker version of the button color. There are variables already created for these colors. For example, we have --primary and --primary-darker variables.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant