Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code review and refacator setOptions function in Dropdown. #897

Open
hbowden opened this issue Jul 9, 2018 · 0 comments
Open

Code review and refacator setOptions function in Dropdown. #897

hbowden opened this issue Jul 9, 2018 · 0 comments

Comments

@hbowden
Copy link
Contributor

hbowden commented Jul 9, 2018

Currently as written the setOptions function in Dropdown has 4 different functions declared and used within the setOptions function its self. The 4 anonymous function should be declared as named functions or named arrow functions outside of setOptions. This will make those functions pure instead of the current implementation that has variables in all functions in scope. When these functions are made pure they will be easier to read, maintain and test. I have a partial refactor I started at home that I can push up later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant