Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CORS Vulnerability in dependency #266

Closed
hbowden opened this issue Aug 25, 2017 · 8 comments
Closed

CORS Vulnerability in dependency #266

hbowden opened this issue Aug 25, 2017 · 8 comments

Comments

@hbowden
Copy link
Contributor

hbowden commented Aug 25, 2017

[748/873] sockjs 0.3.18  [VULNERABLE]
3 known vulnerabilities, 1 affecting installed version

CORS vulnerability
The package automatically sets the `Access-Control-Allow-Origin` header to whatever the requesting doma
in is, if any sockjs path is referenced from another domain. This enables a possible CORS attack.

The fix is a change that optionally disables the CORS headers.

Affected versions: <=0.3.18
References:
  * https://github.com/sockjs/sockjs-node/issues/217
  * https://github.com/sockjs/sockjs-node/pull/218
------------------------------------------------------------```
@Magneticmagnum
Copy link
Contributor

There is currently a PR for this waiting in sockjs github: sockjs/sockjs-node#218 (review)

However, doesn't seem like they are going to fix it. We can fork and use it as it is MIT license.

@hbowden
Copy link
Contributor Author

hbowden commented Sep 13, 2017

Yea we can fork until/if they merge that PR, we can't create a release with a known vulnerability.

@hbowden hbowden added the 0.1.0 label Oct 26, 2017
@NogsMPLS
Copy link
Contributor

FYI, that PR has been merged. update dependencies and run the vulnerability test again to see if this can be closed.

@hbowden
Copy link
Contributor Author

hbowden commented Nov 10, 2017

K sweet, I'll check.

@hbowden
Copy link
Contributor Author

hbowden commented Nov 10, 2017

Still getting the error, we probably need to update one of our deps.

@Magneticmagnum
Copy link
Contributor

Check again? I'm no longer seeing the issue when I used Synk.io to check the repo's dependencies

@stuller
Copy link
Contributor

stuller commented Mar 9, 2018

Can this be closed?

@Magneticmagnum
Copy link
Contributor

No longer seeing the vulnerability. Closing issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants