Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move non-beamline modules out of beamlines package #544

Merged
merged 4 commits into from
May 22, 2024
Merged

Move non-beamline modules out of beamlines package #544

merged 4 commits into from
May 22, 2024

Conversation

callumforrester
Copy link
Contributor

Fixes #543

Suggested location, the alternative is turning dodal.utils into a directory.

Instructions to reviewer on how to test:

  1. Do thing x
  2. Confirm thing y happens

Checks for reviewer

  • Would the PR title make sense to a scientist on a set of release notes
  • If a new device has been added does it follow the standards
  • If changing the API for a pre-existing device, ensure that any beamlines using this device have updated their Bluesky plans accordingly

@callumforrester callumforrester changed the title New beamline utils Move non-beamline modules out of beamlines package May 15, 2024
@callumforrester callumforrester mentioned this pull request May 15, 2024
Merged
3 tasks
@callumforrester
Copy link
Contributor Author

Another alternative is to add to the common package that is already there and make common.beamlines

DominicOram
DominicOram approved these changes May 21, 2024
View reviewed changes
Copy link
Contributor

@DominicOram DominicOram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I'm ambivalent on it's exact location. Here is fine. Could you add this convention in some docs somewhere probably both:

I'm happy for you to then merge without re-review

@callumforrester callumforrester merged commit 156d1ae into main May 22, 2024
11 checks passed
@callumforrester callumforrester deleted the new-beamline-utils branch May 22, 2024 11:49
@DominicOram DominicOram mentioned this pull request May 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DominicOram DominicOram DominicOram approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move non-beamline modules out of beamlines package
2 participants
@callumforrester @DominicOram