Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move non-beamline modules out of beamlines package #543

Closed
callumforrester opened this issue May 15, 2024 · 0 comments · Fixed by #544
Closed

Move non-beamline modules out of beamlines package #543

callumforrester opened this issue May 15, 2024 · 0 comments · Fixed by #544

Comments

@callumforrester
Copy link
Contributor

callumforrester commented May 15, 2024 •
edited 

          We could move `_device_helpers.py` etc. into some other location and just have a convention that only beamline modules live in `beamlines`. Then we can just auto-detect based on all the module names in that folder?

Originally posted by @DominicOram in #519 (comment)

Acceptance Criteria

  • Only beamline modules in dodal.beamlines
  • Non-beamline modules still accessible, but via a different import path
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Move non-beamline modules out of beamlines package DiamondLightSource/dodal
1 participant
@callumforrester