Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Running Count plan against i22 F-Switch gives KeyError #536

Closed
keithralphs opened this issue May 15, 2024 · 0 comments · Fixed by #563
Closed

Running Count plan against i22 F-Switch gives KeyError #536

keithralphs opened this issue May 15, 2024 · 0 comments · Fixed by #563

Comments

@keithralphs
Copy link
Contributor

In testing on i22 on 14/05/24, when the Count plan was run via BlueAPI against the F-Switch device the the following error was reported:

KeyError: number_of_lenses

presumably indicating that there was no corrensponding entry in the device attributes for number_of_lenses

The test was run via BlueAPI but ought to be reproducable using just a command line Bluesky/Ophyd-Async environment

Acceptance Criteria

  • Thte count plan should be runnable aginst the device without producing the error
joeshannon added a commit that referenced this issue May 21, 2024
@joeshannon
Override describe for fswitch
9f1e085 
This must be implemented to allow the device to be used in plans.

Add a simple test to ensure the count plan runs successfully.

Fixes #536.
@joeshannon joeshannon mentioned this issue May 21, 2024
Merged
3 tasks
joeshannon added a commit that referenced this issue May 21, 2024
@joeshannon
Implement describe for fswitch
679953e 
This must be implemented to allow the device to be used in plans.

Add a simple test to ensure the count plan runs successfully.

Fixes #536.
joeshannon added a commit that referenced this issue May 21, 2024
@joeshannon
Implement describe for fswitch
c2d682d 
This must be implemented to allow the device to be used in plans.

Add a simple test to ensure the count plan runs successfully.

Fixes #536.
joeshannon added a commit that referenced this issue May 21, 2024
@joeshannon
Implement describe for fswitch
daf8153 
This must be implemented to allow the device to be used in plans.

Add a simple test to ensure the count plan runs successfully.

Fixes #536.
joeshannon added a commit that referenced this issue May 21, 2024
@joeshannon
Implement describe for fswitch
d05639f 
This must be implemented to allow the device to be used in plans.

Add a simple test to ensure the count plan runs successfully.

Fixes #536.
joeshannon added a commit that referenced this issue May 21, 2024
@joeshannon
Implement describe for fswitch
b02d9a2 
This must be implemented to allow the device to be used in plans.

Add a simple test to ensure the count plan runs successfully.

Fixes #536.
joeshannon added a commit that referenced this issue May 21, 2024
@joeshannon
Implement describe for fswitch (#563)
94c632b 
This must be implemented to allow the device to be used in plans.

Add a simple test to ensure the count plan runs successfully.

Fixes #536.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement describe for fswitch DiamondLightSource/dodal
1 participant
@keithralphs