Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix i22 slits #520

Closed
joeshannon opened this issue May 10, 2024 · 0 comments · Fixed by #521
Closed

Fix i22 slits #520

joeshannon opened this issue May 10, 2024 · 0 comments · Fixed by #521

Comments

@joeshannon
Copy link
Contributor

Six sets of slits were added in #431.

There are a couple of issues:

  • They were added with fake_with_ophyd_sim = True (which is correct for p38 but not i22)
  • They were added with the assumption that all slits are the same however this doesn't appear to be the case - S4 is different to the others and doesn't have {X,Y} centre and size, instead 6 different motors

First part is to set fake_with_ophyd_sim = False.

Second part is to confirm if the hardware is fundamentally different or if the IOC can be changed to present itself as the other slits. If it is different then we probably need an additional slits implementation - in this case a new issue can be made.

Acceptance Criteria

  • All slit devices in the i22 connect or are skipped if a suitable device is not implemented yet.
joeshannon added a commit that referenced this issue May 10, 2024
@joeshannon
Fix i22 slits
d38435b 
* These were added as fake by mistake
* Skip S4 for now as it has a different Epics interface

Fixes #520.
@joeshannon joeshannon mentioned this issue May 10, 2024
Merged
3 tasks
joeshannon added a commit that referenced this issue May 10, 2024
@joeshannon
Fix i22 slits
44d083f 
* These were added as fake by mistake
* Skip S4 for now as it has a different Epics interface

Fixes #520.
joeshannon added a commit that referenced this issue May 21, 2024
@joeshannon
Fix i22 slits
737ec99 
* These were added as fake by mistake
* Skip S4 for now as it has a different Epics interface

Fixes #520.
joeshannon added a commit that referenced this issue May 21, 2024
@joeshannon
Fix i22 slits (#521)
554f53e 
* These were added as fake by mistake
* Skip S4 for now as it has a different Epics interface

Fixes #520.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix i22 slits DiamondLightSource/dodal
1 participant
@joeshannon