Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use tolerances in beamline parameters file for aperture scatterguard #494

Closed
DominicOram opened this issue May 1, 2024 · 2 comments · Fixed by #548
Closed

Use tolerances in beamline parameters file for aperture scatterguard #494

DominicOram opened this issue May 1, 2024 · 2 comments · Fixed by #548
Assignees

Comments

@DominicOram
Copy link
Contributor

For the aperture scatterguard to be in position we currently use the motor tolerances, we should instead use those in the beamline parameters file see https://diamondlightsource.slack.com/archives/C048RD0KFFF/p1714579073626219

Acceptance Criteria

  • Tolerances from beamline parameters file are used in the aperture/scatterguard
@dperl-dls
Copy link
Collaborator

Should there be signals for this or just attributes?

@DominicOram
Copy link
Contributor Author

  • Signal for outside device, attribute otherwise. This is an attribute as will only be internal
  • We already read the file, need to get the tolerances out as well as positions and use those
  • This is just aperture scatterguard for now, ignore the other tolerances in this file
  • Small

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants