Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #767: NPE for IBAN with country code #768

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix #767: NPE for IBAN with country code #768

wants to merge 1 commit into from

Conversation

manosbatsis
Copy link

Fixes #767

There is no easy way to control target country randomization when creating IBANs, because both countryCodeToBasicBankAccountNumberPattern and createCountryCodeToBasicBankAccountNumberPatternMap() are private.

This PR adds a Finance.ibanCountryCodes() to allow finer control of scope.

@bodiam
Copy link

bodiam commented Oct 27, 2023

Hi @manosbatsis , thanks for submitting this fix. I'd suggest trying out Datafaker, a drop in replacement for Javafaker. We're also very open to contributions!

@manosbatsis
Copy link
Author

Hey @bodiam, actually I think datafaker's Finance class has the same issue. Perhaps you'd like the same PR there?

@bodiam
Copy link

bodiam commented Oct 27, 2023

Can you reproduce it with Datafaker? If so, absolutely!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NPE for IBAN with country code
2 participants
@manosbatsis @bodiam