Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tidy up Camunda Platform Helm notes #3

Closed
1 task
aabouzaid opened this issue Jun 12, 2023 · 11 comments
Closed
1 task

Tidy up Camunda Platform Helm notes #3

aabouzaid opened this issue Jun 12, 2023 · 11 comments
Assignees
Labels

Comments

@aabouzaid
Copy link
Collaborator

aabouzaid commented Jun 12, 2023

The Camunda Platform Helm notes could be better.

By doing this task, you will gain the following skills:

  • Basic Helm chart development.

The Challange

Camunda Platform Helm chart has multiple components (applications), and some users don't need all components, so if one of the components is disabled, it should not show in the Helm notes.

The Task

You need to add conditions in the Connecting to Web apps section, so if one of the apps is disabled, it should not appear in the notes.

Also you need to add the Ingress host if it's enabled (it's not mentioned in the notes at all).

Notes

The Helm chart note is not rendered via the helm template [...] command; you need to find a different way to debug it.

Links

@mustafaelghrib
Copy link

Hi @aabouzaid , Okay, I am interested in this, I know Helm a little bit, but I didn't use this camunda before, should I know something before contributing to it? I don't understand the issue.

@aabouzaid
Copy link
Collaborator Author

@mstva I've updated the task, is it clear now?

@mustafaelghrib
Copy link

@aabouzaid Okay, I understand the task now, I will see how to fix it after setup this repo locally, I have some questions:

  • I see that someone has fixed it and it was merged but you opened it again, could I know why? is the solution that he provided not working?
  • you said that "you need to find a different way to debug it" if you are fixing it yourself, what you will do with this? I need some hints

@mustafaelghrib
Copy link

@aabouzaid I found this and I think it is the way I could use it to debug, what do you think?

@mustafaelghrib
Copy link

I added something like this for the ingress issue, what do you think?

- Ingress:
  - Enabled: {{ .Values.global.ingress.enabled }}
  {{- if .Values.global.ingress.enabled }}
  - Ingress Host: {{ .Values.global.ingress.host }}
  {{- end }}

I can't find those Ingress URLs that you are talking about in the issue

Also for the Connecting to Web apps issue, I see that there are conditions that actually do what you ask about, I don't understand your problem.

@aabouzaid
Copy link
Collaborator Author

aabouzaid commented Jun 14, 2023

@mstva let's have a call to give you a better summary.
Send me a message on LinkedIn or Facebook.

@mustafaelghrib
Copy link

@aabouzaid Okay, I sent you an invitation on Linkedin

@mustafaelghrib
Copy link

@aabouzaid I opened a PR

@aabouzaid
Copy link
Collaborator Author

@mustafaelghrib FYI, I'm on vacation till the beginning of July, and I will review it once I'm back.

@aabouzaid
Copy link
Collaborator Author

@mustafaelghrib merged, great job 👏 👏

If you like the Helm topic, there are more advanced tasks 😁

@mustafaelghrib
Copy link

Hi @aabouzaid Yes it would be great!
Is that will be related to Camunda as well?
I see some other issues, I could work on them if that the case. What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

No branches or pull requests

2 participants