New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Since v11, this action now creates a second commit #40
Comments
…0 to 11" This reverts commit b8f5402. v11 of this action has a nasty bug. See: DeterminateSystems/update-flake-lock#40
This reverts commit 9e9e67a. This commit was due to a bug: DeterminateSystems/update-flake-lock#40
Thanks for the report, I'll take a look. Sorry for the unintentional mess! |
I've just published a v12 that fixes this issue (reproduced in cole-h/update-flake-lock-test#26, fix demonstrated in cole-h/update-flake-lock-test#25). Sorry again for the issue, and thanks for opening a ticket about it! |
For a brief bit of background, the action we use to actually create the PR, https://github.com/peter-evans/create-pull-request, commits all new and modified files when it runs, and #38 introduced functionality to customize the PR body by using a template file. The fix was to remove the undesired files before that action runs, as suggested in https://github.com/peter-evans/create-pull-request#remove-files. |
Thanks for this action.
Unfortunately, since v11, the action now creates 2 commits: the flake update, and a second commit that commits
pr_body.template
andpr_body.txt
. For example, see this PR:hackworthltd/hacknix#560
(Unfortunately, I didn't notice this until after Mergify committed the PR.)
(I created that PR by running the action using a manual workflow, so perhaps that's related.)
Here's the resuable workflow we're using, for reference:
https://github.com/hackworthltd/.github/blob/main/.github/workflows/reusable-update-nix-flake-public.yml
Prior to upgrading to v11, it worked great.
The text was updated successfully, but these errors were encountered: