Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding support for gpg commit signing and custom pr body #38

Merged
merged 3 commits into from Jul 27, 2022
Merged

adding support for gpg commit signing and custom pr body #38

merged 3 commits into from Jul 27, 2022

Conversation

edulix
Copy link
Contributor

@edulix edulix commented Jul 15, 2022 •
edited

Description

Implementing commit signing as requested in #37

Still testing, that's why it's a draft PR

Checklist
  • Tested functionality against a test repository (see "How to test changes")
  • Added or updated relevant documentation (leave unchecked if not applicable)
Sample generated PRs

@edulix edulix force-pushed the main branch 14 times, most recently from 63dcd8a to 45d1d69 Compare July 15, 2022 10:19
@edulix edulix marked this pull request as ready for review July 15, 2022 10:45
@edulix edulix marked this pull request as draft July 15, 2022 10:50
@edulix edulix force-pushed the main branch 8 times, most recently from 0b26593 to adc7835 Compare July 15, 2022 11:21
@edulix edulix marked this pull request as ready for review July 15, 2022 11:26
@edulix
Copy link
Contributor Author

edulix commented Jul 15, 2022

This is ready for review, I included two examples in the description.

@cole-h cole-h requested review from cole-h and grahamc July 15, 2022 18:03
cole-h
cole-h approved these changes Jul 27, 2022
View reviewed changes
Copy link
Member

@cole-h cole-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the massive delay! I kept forgetting to bring this up 🙇

This seems good to me. Thank you for the contribution, and the well-written additions to the docs!

@cole-h cole-h merged commit 8c1a465 into DeterminateSystems:main Jul 27, 2022
@cole-h cole-h mentioned this pull request Jul 27, 2022
Closed
@cole-h
Copy link
Member

cole-h commented Jul 27, 2022

FYI, I just released https://github.com/DeterminateSystems/update-flake-lock/releases/tag/v11, which contains this PR.

@cole-h cole-h mentioned this pull request Jul 29, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cole-h cole-h cole-h approved these changes

@grahamc grahamc Awaiting requested review from grahamc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@edulix @cole-h