Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update nix to 0.20 #71

Merged
merged 1 commit into from Feb 23, 2021
Merged

Update nix to 0.20 #71

merged 1 commit into from Feb 23, 2021

Conversation

printfn
Copy link
Contributor

@printfn printfn commented Oct 26, 2020

No description provided.

@Detegr
Copy link
Owner

Detegr commented Oct 26, 2020

Is there a specific reason why nix should be updated to the latest version?

@ghost
Copy link

ghost commented Jan 16, 2021

To throw my 2 cents in, one of nix dependencies is cfg-if. Specifically nix v0.18 depends on cfg-if v0.1.

In one of my projects I also depend on rand which in turn depends on cfg-if v1.0. nix v0.19 upgrades its cfg-if version to 1.0 as well.

Having separate versions in the dependency tree causes issues with, for example, generating documentation as both versions of cfg-if are named the same, but technically are different crates bc of the different versions, so cargo doc throws up a warning about it. So upgrading the version would resolve that clash.

This is a known issue within cargo and its tracking issue can be found here.

My case is a rather knit-picky case and I can continue working just fine without the update, but to update the dependency would be a quality of life improvement in my workflow.

@Nukesor
Copy link

Nukesor commented Feb 23, 2021

First of all, thanks for providing this library :)

I second @Fluhzar's statement. nix 0.20 already got released and ctrlc is one of the main sources of duplicate dependencies in my projects. (duplicate nix version + duplicate cfg-if version).

It would be awesome if this PR could be updated to 0.20 and merged afterwards!

Stuff like this significantly reduces compile-time and at least I consider keeping dependencies up-to-date a best practice.

Thanks again for your time and effort maintaining this library!

Cheers

@printfn printfn changed the title Update nix to 0.19 Update nix to 0.20 Feb 23, 2021
@Detegr Detegr merged commit e002097 into Detegr:master Feb 23, 2021
@Detegr
Copy link
Owner

Detegr commented Feb 23, 2021

Thanks for the comments and sorry for taking so long :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants