Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ButtonGroup and ButtonMenu Should Pass "theme" Prop Down #40

Open
machineghost opened this issue Sep 18, 2020 · 0 comments
Open

ButtonGroup and ButtonMenu Should Pass "theme" Prop Down #40

machineghost opened this issue Sep 18, 2020 · 0 comments

Comments

@machineghost
Copy link

ButtonGroup and ButtonMenu components can already pass down a size property to their buttons, so:

<ButtonGroup size="sm">
  <Button>Foo</Button>
  <Button>Bar</Button>
</ButtonGroup>

is the same as:

<ButtonGroup>
  <Button size="sm">Foo</Button>
  <Button size="sm">Bar</Button>
</ButtonGroup>

In the same fashion, it would be nice if you could set "theme" on a group/menu, so that (for instance) if you wanted a group of dark buttons you could do so with:

<ButtonGroup theme="dark">
  <Button>Foo</Button>
  <Button>Bar</Button>
</ButtonGroup>

This seems like it would be simple enough to add, so I could potentially submit a PR if desired.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant