Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow tag to be a component #29

Open
sammy2077 opened this issue Nov 23, 2019 · 2 comments
Open

Allow tag to be a component #29

sammy2077 opened this issue Nov 23, 2019 · 2 comments

Comments

@sammy2077
Copy link

sammy2077 commented Nov 23, 2019

When i pass a component as a tag to supported element like Nav

import { Link } from 'react-router-dom';

<NavbarBrand tag={Link} to="/">
          Agweria
</NavbarBrand>

I get the error : Failed prop type: Invalid prop tag supplied to NavbarBrand
See console error

image

Though it works fine even in the above case, is there a way to get rid of the console error.

See . facebook/prop-types#211

@jorgeotavio
Copy link

I am also experiencing this problem, which happened when I upgraded React-router-dom to the latest version 5.1.2.

@bvanhou
Copy link

bvanhou commented Mar 13, 2020

Anything updates on this? @design-revision

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants