Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change all XML comments to Liquid comments #69

Open
Rabadash8820 opened this issue May 21, 2023 · 0 comments
Open

Change all XML comments to Liquid comments #69

Rabadash8820 opened this issue May 21, 2023 · 0 comments
Assignees

Comments

@Rabadash8820
Copy link
Member

Rabadash8820 commented May 21, 2023

XML comments (<!-- like this -->) still get rendered by Jekyll, which means they still get downloaded by site visitors. No reason to add those additional bytes (and anybody who cares can look at this source code anyway), so let's just convert them to the Liquid templating system's comments ({% comment %}like this {% endcomment %}. WAY more verbose, but better performance. 🤷‍♂️ Liquid v5 does have a tighter inline comment syntax, but as of this writing, Jekyll is still on Liquid v4 and there's no way to force it to use v5.

@Rabadash8820 Rabadash8820 self-assigned this May 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant