Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code cleanup and fix flake8 errors #353

Closed
AndrewYakimets opened this issue Oct 21, 2020 · 4 comments
Closed

Code cleanup and fix flake8 errors #353

AndrewYakimets opened this issue Oct 21, 2020 · 4 comments
Labels
enhancement Improvement to an already existing feature

Comments

@AndrewYakimets
Copy link
Contributor

Hi, I am having a big desire to make my first contribution. And I would really like to start with helping loguru! I saw there is some unused imports (for e.g., setup.py:1), code that is hard to read and can be improved (loguru/init.py:17 - add key/value to params) and some amout of flake8 errors (mostly in tests). I would like to fix it and make the contribution to loguru.

Could you, please, tell me if I am allowed to do so and you don't mind?

@Delgan
Copy link
Owner

Delgan commented Oct 22, 2020

Hi @AndrewYakimets.

Thanks for your interest in loguru and thanks for offering enhancing it. Of course, I would happily accept any improvement! Code cleanups are welcome. 😉

@AndrewYakimets
Copy link
Contributor Author

Hi @Delgan , thank you for fast response! Okay, I am starting 😃

@AndrewYakimets
Copy link
Contributor Author

AndrewYakimets commented Oct 26, 2020

Hi, @Delgan!

I've finished implementing my proposed changes in PR #354. The CI checks were passed.

Could you, please, check it?

@Delgan
Copy link
Owner

Delgan commented Oct 26, 2020

Checked and merged, thanks!

@Delgan Delgan closed this as completed Oct 26, 2020
@Delgan Delgan added the enhancement Improvement to an already existing feature label Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement to an already existing feature
Projects
None yet
Development

No branches or pull requests

2 participants