version 18.8.4 , dom onclick event type error，18.8.3 is normal

[FrontEndDog]

node version 14.19.3
typescript version 4.8.4

[daniluk4000]

Same error with most of DOM types

[heavenshell]

I've got below type errors when updated to v18.8.4.

TypeScript: 4.8.4
Node: v18.10.0, v16.17.0

tsc -p tsconfig.json --noEmit
node_modules/@storybook/api/dist/ts3.9/modules/shortcuts.d.ts:55:18 - error TS2430: Interface 'Event' incorrectly extends interface 'KeyboardEvent'.
  Types of property 'target' are incompatible.
    Property 'prototype' is missing in type '{ tagName: string; addEventListener(): void; removeEventListener(): boolean; dispatchEvent(event: Event): boolean; getAttribute(attr: string): string | null; }' but required in type 'EventTarget'.

55 export interface Event extends KeyboardEvent {
                    ~~~~~

  node_modules/typescript/lib/lib.dom.d.ts:5162:5
    5162     prototype: EventTarget;
             ~~~~~~~~~
    'prototype' is declared here.


Found 1 error in node_modules/@storybook/api/dist/ts3.9/modules/shortcuts.d.ts:55

[FrontEndDog]

This may be a problem with vue，please see

vuejs/core#6855

[daniluk4000]

@FrontEndDog I still use Vue 2.6.12. The only thing I updated is @types/node.

I've created a very simple reproduction of my problem without 3rd-party libs here: https://github.com/daniluk4000/types-node-error

[FrontEndDog]

@FrontEndDog I still use Vue 2.6.12. The only thing I updated is @types/node.

I've created a very simple reproduction of my problem without 3rd-party libs here: https://github.com/daniluk4000/types-node-error

yes，I reappeared， This problem still exists with 18.8.5

[falsandtru]

#62729 will fix them.

[kesupile]

Hello! I've also encountered a similar issue with DOM types. In my case the HTMLElement type is showing some strange/incorrect behaviour.

Version 18.8.3 ✅

Version 18.8.4 ❌

element should be () => HTML | null inside the type guard, but it is still MaybeFn. This problem is still present in the latest release (v18.11.0)