xmldom types include globals that don't exist in Node

[justinfagnani]

• I tried using the @types/xxxx package and had problems.
• I tried using the latest stable version of tsc. https://www.npmjs.com/package/typescript
• I understand that @types package versions do not follow SemVer.
• I have a question that is inappropriate for StackOverflow. (Please ask any appropriate questions there).
• Mention the authors (see Definitions by: in index.d.ts) so they can respond.
  • Authors: @tkqubo @karfau

The xmldom types reference TypeScript's DOM typings with /// <reference lib="dom" />. This causes any module that imports xmldom to get the entire DOM typings, including globals like document.

With those globals defined we lose errors when accidentally referencing them, which can obviously cause crashes.

It'd be great if xmldom could pick off only the DOM types that it uses and exports, like DOMImplementation, Document, Node, etc. I'm not sure if this is possible with lib.dom.d.ts

[karfau]

@justinfagnani thank you for reporting the issue!

Can you try something to see if it works as I understood the docs:
In the project (is it a public one?) after yarn/npm install go to
node_modules/@types/xmldom/index.d.ts
and apply the following change:

- /// <reference lib="dom" />
+ /// <reference types="dom" />

and check if your problem is solved.
(If that works I will provide a PR.)

Thank you

[justinfagnani]

@Karfu that doesn't work since types looks in the places where userland types are (@types, the types config, etc.) "dom" is a built-in library like "es2020".

[markdon]

Maybe the built in dom types shouldn't be used at all. xmldom doesn't implement the entire interface for the built in Document and Element types. It's at least missing the querySelector functions.

[karfau]

I think you are right. And I think the effort to either manually write or generate the types that are actually supported is not to big.
I might even be able to support the integration of the types into the actual package.
But the resources in the xmldom project are really limited currently.
Any support would be useful.

[brodybits]

FYI updates are now published as @xmldom/xmldom, which includes the types as of version 0.7.1, as discussed here: xmldom/xmldom#271

We have discussion of the @xmldom/xmldom types here: xmldom/xmldom#191, xmldom/xmldom#285

[ab-pm]

Related issues for other libs: #55382, node-fetch/node-fetch#1285

Ideas to fix this issue properly: microsoft/TypeScript-DOM-lib-generator#1207, microsoft/TypeScript#33111, microsoft/TypeScript#43990