Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add badges to indicate config values that are reloadable #19

Closed
IanVS opened this issue Mar 22, 2022 · 2 comments · Fixed by #125
Closed

Add badges to indicate config values that are reloadable #19

IanVS opened this issue Mar 22, 2022 · 2 comments · Fixed by #125
Labels
kicked can A task that we intend to implement.... someday...

Comments

@IanVS
Copy link
Collaborator

IanVS commented Mar 22, 2022

Changing some values in the config require shutting down and restarting nebula, and some don't. We should make it clear which can be reloaded (at least in the most recent version of nebula).
@jasikpark jasikpark mentioned this issue Jun 2, 2022
Closed
@jasikpark
Copy link
Collaborator

#27 was meant to regard this, but some values are reloadable in different ways and others are reloadable on only some systems, so this was kicked into the future

@jasikpark jasikpark added the kicked can A task that we intend to implement.... someday... label Sep 2, 2022
@jasikpark
Copy link
Collaborator

Hopefully we can someday remove this ticket by enabling soft-reload for all config items

@IanVS IanVS mentioned this issue May 22, 2024
Merged
IanVS added a commit that referenced this issue May 29, 2024
@IanVS
Document reloadable configs (#125)
4f72fda 
Closes #19

We didn't have any good listing of which options can be reloaded via a
SIGHUP vs those that require a full restart to take effect. This adds a
simple badge to indicate which options can be reloaded. AFAICT,
`tun.mtu` is only reloadable on linux, but that's the only difference
between platforms that I could find.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kicked can A task that we intend to implement.... someday...
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Document reloadable configs DefinedNet/nebula-docs
2 participants
@IanVS @jasikpark