From 6f005575d649d9286f137b94940f8b0022e30fc4 Mon Sep 17 00:00:00 2001 From: Srijan Saurav <68371686+srijan-deepsource@users.noreply.github.com> Date: Mon, 30 May 2022 16:19:26 +0530 Subject: [PATCH] Revert "fix: function-paren-newline crash on "new new Foo();" (#15850)" This reverts commit b8b86c288ae4c26cbb02635e0857b09d2e394ce6. --- lib/rules/function-paren-newline.js | 11 ++++------- tests/lib/rules/function-paren-newline.js | 13 ------------- 2 files changed, 4 insertions(+), 20 deletions(-) diff --git a/lib/rules/function-paren-newline.js b/lib/rules/function-paren-newline.js index a5b8f0d70c6..898e113ee8e 100644 --- a/lib/rules/function-paren-newline.js +++ b/lib/rules/function-paren-newline.js @@ -191,13 +191,10 @@ module.exports = { function getParenTokens(node) { switch (node.type) { case "NewExpression": - if (!node.arguments.length && - !( - astUtils.isOpeningParenToken(sourceCode.getLastToken(node, { skip: 1 })) && - astUtils.isClosingParenToken(sourceCode.getLastToken(node)) && - node.callee.range[1] < node.range[1] - ) - ) { + if (!node.arguments.length && !( + astUtils.isOpeningParenToken(sourceCode.getLastToken(node, { skip: 1 })) && + astUtils.isClosingParenToken(sourceCode.getLastToken(node)) + )) { // If the NewExpression does not have parens (e.g. `new Foo`), return null. return null; diff --git a/tests/lib/rules/function-paren-newline.js b/tests/lib/rules/function-paren-newline.js index a8c7cc85827..048370f356a 100644 --- a/tests/lib/rules/function-paren-newline.js +++ b/tests/lib/rules/function-paren-newline.js @@ -30,7 +30,6 @@ const ruleTester = new RuleTester({ parserOptions: { ecmaVersion: 6 } }); ruleTester.run("function-paren-newline", rule, { valid: [ - "new new Foo();", // multiline option (default) "function baz(foo, bar) {}", @@ -1175,18 +1174,6 @@ ruleTester.run("function-paren-newline", rule, { options: ["never"], errors: [LEFT_UNEXPECTED_ERROR] }, - { - code: ` - new new C()( - ); - `, - output: ` - new new C()(); - `, - options: ["never"], - errors: [LEFT_UNEXPECTED_ERROR, RIGHT_UNEXPECTED_ERROR] - }, - { code: ` function baz(