From 299d6df7ed263a14ff1f8ea7a7728324e814460c Mon Sep 17 00:00:00 2001 From: Srijan Saurav <68371686+srijan-deepsource@users.noreply.github.com> Date: Mon, 30 May 2022 16:19:26 +0530 Subject: [PATCH] Revert "feat: update eslint-scope to ignore `"use strict"` directives in ES3 (#15595)" This reverts commit b388fbfe9b365bc326e9b731ef27dbaa13f47c3d. --- package.json | 2 +- tests/lib/rules/no-eval.js | 7 ------- tests/lib/rules/no-invalid-this.js | 8 -------- 3 files changed, 1 insertion(+), 16 deletions(-) diff --git a/package.json b/package.json index 800cbc88dba..9ddea098285 100644 --- a/package.json +++ b/package.json @@ -55,7 +55,7 @@ "debug": "^4.3.2", "doctrine": "^3.0.0", "escape-string-regexp": "^4.0.0", - "eslint-scope": "^7.1.1", + "eslint-scope": "^7.1.0", "eslint-utils": "^3.0.0", "eslint-visitor-keys": "^3.3.0", "espree": "^9.3.1", diff --git a/tests/lib/rules/no-eval.js b/tests/lib/rules/no-eval.js index b084892cf2e..79ba4a1eb11 100644 --- a/tests/lib/rules/no-eval.js +++ b/tests/lib/rules/no-eval.js @@ -139,13 +139,6 @@ ruleTester.run("no-eval", rule, { code: "class A { static {} [this.eval()]; }", parserOptions: { ecmaVersion: 2022 }, errors: [{ messageId: "unexpected" }] - }, - - // in es3, "use strict" directives do not apply - { - code: "function foo() { 'use strict'; this.eval(); }", - parserOptions: { ecmaVersion: 3 }, - errors: [{ messageId: "unexpected" }] } ] }); diff --git a/tests/lib/rules/no-invalid-this.js b/tests/lib/rules/no-invalid-this.js index 6b54d9a965e..90cbdef98ac 100644 --- a/tests/lib/rules/no-invalid-this.js +++ b/tests/lib/rules/no-invalid-this.js @@ -865,14 +865,6 @@ const patterns = [ valid: [NORMAL], invalid: [USE_STRICT, IMPLIED_STRICT, MODULES], errors: [{ messageId: "unexpectedThis", type: "ThisExpression" }] - }, - - // in es3, "use strict" directives do not apply - { - code: "function foo() { 'use strict'; this.eval(); }", - parserOptions: { ecmaVersion: 3 }, - valid: [NORMAL, USE_STRICT, IMPLIED_STRICT], - invalid: [] } ];